anvilsign in

collin/anvil

b6833865231aa6afb6d11a5589ff29162a04e005 / TODO.md

BoardRenderedSource

Misc TODO5 open

  1. should show subject line of latest commit in repo page view
    • we should mirror certain things like this from github ui
  2. don't expose a users email on their profile page
  3. don't include anvil before the breadcrumbs in the repo name i.e. anvil/collin/repo just do collin/repo
  4. implement github action style CI feature (core done — see "Session notes" below; the "isolated workers" idea is the (c) sandboxed broker, still TODO)
    • I want to get this to a sufficient state that we could bootstrap this app using this CI and automate deployments if we wished
    • probably might want to have other isolated anvil workers or something running for CI jobs
  5. implement github pages style hosting feature
  6. security audit (started: see (b) threat-model below)

Session notes / resume point6 open

  1. Done this session
    • CI UI — runs list /{owner}/{repo}/ci, run-detail (status/timing/log), per-commit status badges, "CI" nav link. (crates/anvil-web/src/ui.rs)
    • CD redeploy webhook — on a green run of [ci] deploy_branch in the single [ci] deploy_repo, POST to [ci] deploy_webhook (X-Anvil-Deploy-Secret header). Scoped to ONE repo. CiConfig in crates/anvil-core/src/config.rs; deploy() in crates/anvil-ci/src/lib.rs. Docs: DEPLOY.md §7, deploy/anvil.toml. reqwest added with NO TLS feature (keeps musl cross-compile aws-lc-free).
    • Docker socket on hagrid — deploy/run.sh mounts it + --group-adds the gid for the non-root user; caveat in DEPLOY.md §4.
    • Toasty ORM cleanup — ci.rs list_by_repo/latest_for_commit/ queued_ids now sort/limit/filter in SQL, not in memory. Verified by the new ordering_and_limit_run_in_the_database test. (Sweep: these were the only real instances; repos::list_all_with_owner sorts by a joined username and needs all rows — intentionally left.)
    • (a) CSRF + cookie hardening —
      • Cookie: HttpOnly + SameSite=Lax + Secure (auto via Config::secure_cookies() when base_url is https).
      • Synchronizer token HMAC-SHA256(server_secret, session); secret persisted at data_dir/csrf_secret (App::csrf_token in crates/anvil-core/src/lib.rs). Deps hmac, sha2.
      • Csrf extractor + constant-time verify_csrf (crates/anvil-web/src/auth.rs). Hidden csrf field + verification on add/delete SSH key, new repo, repo settings. Login exempt; logout relies on SameSite.
      • htmx insurance: auth::csrf_context middleware → request-scoped task-local; layout sends the token via hx-headers on every htmx request.
  2. Next up (the agreed a/b/c plan — (a) done)
  3. (b) untrusted-mode threat-model doc ← START HERE

    Write docs/untrusted-mode.md (or SECURITY.md). Capture the severity-ranked analysis:

    1. CI runner = root-equiv RCE via Docker socket — the hard blocker; fix is (c).
    2. Stored XSS if we ever serve raw blobs → separate origin + text/plain + CSP.
    3. Git resource exhaustion (pack/decompression bombs, huge ref ads) → size/ storage quotas + timeouts.
    4. Open registration anti-abuse (email verify, rate limit, CAPTCHA, quotas, ban).
    5. Authorization granularity → collaborator roles + per-repo tokens / deploy keys.
    6. Webhook SSRF (when webhooks land) → block private IPs / metadata / localhost. Already-right: private repos 404 (no leak), reserved usernames + /-/, CI tar-upload (not bind-mount), single-repo CD gate, argon2, CSRF + Secure cookies. Recommendation to record: single-tenant/owner-operated stays the supported stance; untrusted is gated behind (c).
  4. (c) sandboxed CI broker

    Make anvil the only Docker client; the job container gets NO socket. Forbid bind mounts; --cap-drop=ALL, --security-opt=no-new-privileges, read-only rootfs, non-root uid, --pids-limit, mem/cpu caps, wall-clock timeout, egress limits, image allowlist + CI-minute quotas. Stronger tier: gVisor/Kata/Firecracker microVMs (this is the "isolated workers" idea from the list above). Current runner: crates/anvil-ci/src/lib.rs::execute.

  5. Loose ends
    • CSRF header consumption: hx-headers sends the token as a csrf header, but verify_csrf only reads the form field. When we add a tokenless htmx action (raw hx-post/hx-delete, no <form>), also read the csrf header.
    • Toasty migrations: schema only pushed on a fresh DB (db::connect); new columns won't apply to an existing DB until migrations land. (The data_dir/csrf_secret file is created automatically — no DB change.)
    • Suggested commits when ready: (1) CI UI, (2) CD webhook + deploy wiring, (3) ci.rs ORM cleanup + test, (4) CSRF + cookies. Trailer: Co-Authored-By: Claude ....
  6. Remaining roadmap (plan milestones beyond a/b/c)
    1. Issues · 9. Pull requests (gix merge) · 10. Webhooks (mind the SSRF item) · github-pages-style static hosting (your list item).
notes

Error in git push (FIXED 2026-06-10, uncommitted)

Root cause: every push after the first sends a thin pack — deltas whose base objects aren't in the pack (the server already has them), referenced by object id (REF_DELTA). vendor/gitserver-core/src/receive_pack.rs::write_pack passed None as thin_pack_base_object_lookup to gix_pack::Bundle::write_to_directory, so gix couldn't resolve the bases and aborted. First-push-to-empty-repo worked because that pack is self-contained.

Fix: pass the already-open gix::Repository as the lookup (it implements gix_object::Find). Regression test receive_thin_pack_with_ref_deltas builds a real thin pack via git pack-objects --thin, asserts it contains ref-deltas, and pushes it through receive_pack. Verified the test fails without the fix.

Original report:

collin@mini ~/C/anvil (main)> git push
Enter passphrase for key '/Users/collin/.ssh/id_ed25519':
Enumerating objects: 117, done.
Counting objects: 100% (117/117), done.
Delta compression using up to 8 threads
Compressing objects: 100% (62/62), done.
Writing objects: 100% (66/66), 27.57 KiB | 3.94 MiB/s, done.
Total 66 (delta 39), reused 0 (delta 0), pack-reused 0 (from 0)
send-pack: unexpected disconnect while reading sideband packet
fatal: the remote end hung up unexpectedly
collin@mini ~/C/anvil (main) [128]>

server logs:

26-06-09T21:53:46.466577Z  INFO anvil_ssh: ssh auth: accepted key SHA256:Rg41caN7vw2WYYxiJN6lrIlX0DTXYF0rC2QzKZW1tB0 (user 1)
2026-06-09T21:53:46.635946Z  INFO anvil_ssh: ssh git-receive-pack on collin/anvil.git (user Some(1))
2026-06-09T21:53:46.805146Z ERROR anvil_ssh: git ssh git-receive-pack: protocol error: failed to write incoming pack: Ref delta objects are not supported as there is no way to look them up. Resolve them beforehand.
2026-06-09T21:54:28.571834Z  INFO anvil_ssh: ssh auth: rejected unknown key SHA256:ZlWZyHqspqFeUQV84qaXtDQq4gcA33dR7y8dYbeg9u8
2026-06-09T21:54:35.565597Z  INFO anvil_ssh: ssh auth: accepted key SHA256:Rg41caN7vw2WYYxiJN6lrIlX0DTXYF0rC2QzKZW1tB0 (user 1)
2026-06-09T21:54:35.676113Z  INFO anvil_ssh: ssh git-receive-pack on collin/anvil.git (user Some(1))
2026-06-09T21:54:36.268520Z ERROR anvil_ssh: git ssh git-receive-pack: protocol error: failed to write incoming pack: Ref delta objects are not supported as there is no way to look them up. Resolve them beforehand.
2026-06-09T21:55:54.223033Z  INFO anvil_ssh: ssh auth: rejected unknown key SHA256:ZlWZyHqspqFeUQV84qaXtDQq4gcA33dR7y8dYbeg9u8
2026-06-09T21:56:00.758384Z  INFO anvil_ssh: ssh auth: accepted key SHA256:Rg41caN7vw2WYYxiJN6lrIlX0DTXYF0rC2QzKZW1tB0 (user 1)
2026-06-09T21:56:00.906553Z  INFO anvil_ssh: ssh git-receive-pack on collin/anvil.git (user Some(1))
2026-06-09T21:56:01.067903Z ERROR anvil_ssh: git ssh git-receive-pack: protocol error: failed to write incoming pack: Ref delta objects are not supported as there is no way to look them up. Resolve them beforehand.